Typescript module API#3327
Merged
Merged
Conversation
0b4dac9 to
ec79ad5
Compare
ff1fe7b to
a9e52b4
Compare
2dadf39 to
b61972b
Compare
Co-authored-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com> Signed-off-by: Noa <coolreader18@gmail.com>
Co-authored-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com> Signed-off-by: Noa <coolreader18@gmail.com>
b61972b to
10f1006
Compare
bfops
reviewed
Oct 15, 2025
Merged
joshua-spacetime
pushed a commit
that referenced
this pull request
Oct 16, 2025
# Description of Changes Host-side changes extracted from #3327 I added AUTO_INC_OVERFLOW even though we don't currently ever return it, in order to future-proof so it's already there when we start emitting it. Prepublish was failing because it was expecting a wasm module unconditionally, so now it takes ?host_type. I tweaked JS deser to accept null/undefined when the unit type or an option type is expected. I switched to bsatn, because the native sats->js translator wasn't matching what js was expecting. I renamed the sys module: my thinking is that `spacetime:` as a scheme will help disambiguate it, and maybe it could also be used for IMC in the future or something? And I believe we had discussed wanting this to be versioned, similar to wasm imports. Trying to get a borrowed str from deserialize_js doesn't work, because v8 strings don't store utf8. # Testing <!-- Describe any testing you've done, and any testing you'd like your reviewers to do, so that you're confident that all the changes work as expected! --> - [x] All this was done in the course of getting an actual typescript module to successfully publish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Currently based on #3361
Implements most of the TS module API (not yet a function for type aliases).
Expected complexity level and risk
Testing